diff options
author | Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> | 2021-03-12 19:20:34 +0100 |
---|---|---|
committer | Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> | 2021-03-17 18:32:23 +0100 |
commit | 9abbf39fa6f23fed903f63b3397dd4f3fac1ea21 (patch) | |
tree | 772c50643cb15400fab0a30149d8116e45449b3d | |
parent | 7791f472f3d545b5bf0cd589f49e47a3dc1cc932 (diff) | |
download | hardware_replicant_libsamsung-ipc-9abbf39fa6f23fed903f63b3397dd4f3fac1ea21.tar.gz hardware_replicant_libsamsung-ipc-9abbf39fa6f23fed903f63b3397dd4f3fac1ea21.tar.bz2 hardware_replicant_libsamsung-ipc-9abbf39fa6f23fed903f63b3397dd4f3fac1ea21.zip |
tools: fix nv-data-md5 compilation with Replicant 6
When compiling nv-data-md5 under Replicant 6 we have:
hardware/replicant/libsamsung-ipc/tools/nv_data-md5.c:
In function 'main':
hardware/replicant/libsamsung-ipc/tools/nv_data-md5.c:103:1:
error:
control reaches end of non-void function [-Werror=return-type]
}
^
cc1: some warnings being treated as errors
So we simply need to add a return in the error path.
While we're at it, we use an exit code referenced in sysexits.h
to follow a standard. This can help differentiating between
different types of errors.
Thanks to that, it can also simplify the code when writing tests.
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
-rw-r--r-- | tools/nv_data-md5.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/nv_data-md5.c b/tools/nv_data-md5.c index e8c9fc8..5edb257 100644 --- a/tools/nv_data-md5.c +++ b/tools/nv_data-md5.c @@ -20,6 +20,7 @@ #include <stdio.h> #include <stdlib.h> #include <string.h> +#include <sysexits.h> #include <sys/types.h> @@ -100,4 +101,6 @@ int main(int argc, char *argv[]) error: if (client != NULL) ipc_client_destroy(client); + + return EX_SOFTWARE; } |