summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPankaj Garg <pgarg@codeaurora.org>2015-09-07 15:09:40 +0200
committerjrizzoli <joey@cyanogenmoditalia.it>2015-09-07 15:09:40 +0200
commitcf3f5fdf99963dabb479128e90ce9f605298548e (patch)
treeb1d6b14f063e440e647b1d99d706d46cd944ffd5
parent15b70af63c3fc1d96e9ec19a12dcb423ecc132cc (diff)
downloadandroid_packages_apps_Gello-cf3f5fdf99963dabb479128e90ce9f605298548e.tar.gz
android_packages_apps_Gello-cf3f5fdf99963dabb479128e90ce9f605298548e.tar.bz2
android_packages_apps_Gello-cf3f5fdf99963dabb479128e90ce9f605298548e.zip
Fixed issue for adding bookmarks to a new folder
- The browser was crashing when user tried to add a bookmark to a new folder. The folder was created using folder selector UI on "add bookmark" dialog page. - If user rotates screen while creating a new folder to add bookmark, the keyboard was not getting dismissed. It caused an overlay on top of the folder selector. The user had to manually dismiss the keyboard. Change-Id: I5f2dbf6e00ab0a1d5b98bf72a04317c04ac0549a
-rw-r--r--src/res/layout/new_folder_layout.xml1
-rw-r--r--src/src/com/android/browser/AddBookmarkPage.java4
-rw-r--r--src/src/com/android/browser/BrowserYesNoPreference.java1
3 files changed, 4 insertions, 2 deletions
diff --git a/src/res/layout/new_folder_layout.xml b/src/res/layout/new_folder_layout.xml
index 3ffa7911..85deee18 100644
--- a/src/res/layout/new_folder_layout.xml
+++ b/src/res/layout/new_folder_layout.xml
@@ -30,7 +30,6 @@
<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:background="@*android:drawable/edit_text_holo_dark"
android:gravity="center_vertical"
android:paddingBottom="5dip"
android:orientation="horizontal">
diff --git a/src/src/com/android/browser/AddBookmarkPage.java b/src/src/com/android/browser/AddBookmarkPage.java
index 860e00a2..00b892ab 100644
--- a/src/src/com/android/browser/AddBookmarkPage.java
+++ b/src/src/com/android/browser/AddBookmarkPage.java
@@ -351,6 +351,8 @@ public class AddBookmarkPage extends Activity
mSaveToHomeScreen = true;
break;
case FolderSpinnerAdapter.OTHER_FOLDER:
+ setupTopCrumb();
+ getLoaderManager().restartLoader(LOADER_ID_FOLDER_CONTENTS, null, this);
switchToFolderSelector();
break;
case FolderSpinnerAdapter.RECENT_FOLDER:
@@ -382,7 +384,7 @@ public class AddBookmarkPage extends Activity
mAddNewFolder.setVisibility(View.VISIBLE);
mAddSeparator.setVisibility(View.VISIBLE);
getInputMethodManager().hideSoftInputFromWindow(
- mListView.getWindowToken(), 0);
+ mFolderNamer.getWindowToken(), 0);
}
private long addFolderToCurrent(String name) {
diff --git a/src/src/com/android/browser/BrowserYesNoPreference.java b/src/src/com/android/browser/BrowserYesNoPreference.java
index d73ea08b..eae9a8b8 100644
--- a/src/src/com/android/browser/BrowserYesNoPreference.java
+++ b/src/src/com/android/browser/BrowserYesNoPreference.java
@@ -50,6 +50,7 @@ public class BrowserYesNoPreference extends DialogPreference {
mNeutralBtnTxt = a.getString(R.styleable.BrowserYesNoPreference_neutralButtonText);
mPositiveBtnTxt = a.getString(R.styleable.BrowserYesNoPreference_positiveButtonText);
mNegativeBtnTxt = a.getString(R.styleable.BrowserYesNoPreference_negativeButtonText);
+ setDialogIcon(R.drawable.ic_sp_level_warning);
}
@Override