summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFlamefire <alex@grundis.de>2014-01-20 21:18:05 (GMT)
committerFlamefire <alex@grundis.de>2014-01-20 21:18:05 (GMT)
commit8dce36332dab83bb99760391b756099a0249f424 (patch)
tree25a75111974359842a97675b8ed72e912b64fe32
parent51af4fccfdbb73eec677962ec138d7b435bcbc50 (diff)
downloadandroid_hardware_samsung-cm-10.2.zip
android_hardware_samsung-cm-10.2.tar.gz
android_hardware_samsung-cm-10.2.tar.bz2
There is a race condition where the sysfs-vsync thread accesses a value (in particular a function ptr) that may not have been set yet as this is done externally. Change-Id: If1afb1533344e994398b9b6f5bd3dfb125313416
-rw-r--r--exynos4/hal/libhwcomposer/SecHWC.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/exynos4/hal/libhwcomposer/SecHWC.cpp b/exynos4/hal/libhwcomposer/SecHWC.cpp
index 1831125..0951ba3 100644
--- a/exynos4/hal/libhwcomposer/SecHWC.cpp
+++ b/exynos4/hal/libhwcomposer/SecHWC.cpp
@@ -965,7 +965,8 @@ static void *hwc_vsync_sysfs_loop(void *data)
do {
ssize_t len = read(vsync_timestamp_fd, buf, sizeof(buf));
timestamp = strtoull(buf, NULL, 0);
- ctx->procs->vsync(ctx->procs, 0, timestamp);
+ if(ctx->procs && ctx->procs->vsync)
+ ctx->procs->vsync(ctx->procs, 0, timestamp);
select(vsync_timestamp_fd + 1, NULL, NULL, &exceptfds, NULL);
lseek(vsync_timestamp_fd, 0, SEEK_SET);
} while (1);