summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWei Jia <wjia@google.com>2015-08-20 23:03:14 (GMT)
committerAbhishek Arya <aarya@google.com>2015-08-21 13:51:40 (GMT)
commit5d2e7de37d4a28cf25cc5d0c64b3a29c1824dc0a (patch)
treefd451b7047d833d7f010aff4790dd412c9701b2e
parent8cbef48ba6e3d3f844b895f8ca1a1aee74414fff (diff)
downloadandroid_external_sonivox-5d2e7de37d4a28cf25cc5d0c64b3a29c1824dc0a.zip
android_external_sonivox-5d2e7de37d4a28cf25cc5d0c64b3a29c1824dc0a.tar.gz
android_external_sonivox-5d2e7de37d4a28cf25cc5d0c64b3a29c1824dc0a.tar.bz2
Sonivox: fix overflow in Parse_data in eas_mdls.c
Bug: 23307276 Change-Id: Iea56eae9a1855b41840f8d814717fe6379c5bb4d
-rw-r--r--arm-wt-22k/lib_src/eas_mdls.c24
1 files changed, 24 insertions, 0 deletions
diff --git a/arm-wt-22k/lib_src/eas_mdls.c b/arm-wt-22k/lib_src/eas_mdls.c
index d66c734..f260c05 100644
--- a/arm-wt-22k/lib_src/eas_mdls.c
+++ b/arm-wt-22k/lib_src/eas_mdls.c
@@ -139,6 +139,14 @@ extern double log10(double x);
#define DLS_MAX_INST_COUNT 256
#define MAX_DLS_WAVE_SIZE (1024*1024)
+#ifndef EAS_U32_MAX
+#define EAS_U32_MAX (4294967295U)
+#endif
+
+#ifndef EAS_I32_MAX
+#define EAS_I32_MAX (2147483647)
+#endif
+
/*------------------------------------
* typedefs
*------------------------------------
@@ -1126,6 +1134,14 @@ static EAS_RESULT Parse_wsmp (SDLS_SYNTHESIZER_DATA *pDLSData, EAS_I32 pos, S_WS
/* get loop length */
if ((result = EAS_HWGetDWord(pDLSData->hwInstData, pDLSData->fileHandle, &p->loopLength, EAS_FALSE)) != EAS_SUCCESS)
return result;
+
+ /* ensure no overflow */
+ if (p->loopLength
+ && ((p->loopStart > EAS_U32_MAX - p->loopLength)
+ || (p->loopStart + p->loopLength > EAS_U32_MAX / sizeof(EAS_SAMPLE))))
+ {
+ return EAS_FAILURE;
+ }
}
return EAS_SUCCESS;
@@ -1272,7 +1288,15 @@ static EAS_RESULT Parse_data (SDLS_SYNTHESIZER_DATA *pDLSData, EAS_I32 pos, EAS_
/* for looped samples, copy the last sample to the end */
if (pWsmp->loopLength)
+ {
+ if (pDLSData->wavePoolSize < sizeof(EAS_SAMPLE)
+ || (pWsmp->loopStart + pWsmp->loopLength) * sizeof(EAS_SAMPLE) > pDLSData->wavePoolSize - sizeof(EAS_SAMPLE))
+ {
+ return EAS_FAILURE;
+ }
+
pSample[pWsmp->loopStart + pWsmp->loopLength] = pSample[pWsmp->loopStart];
+ }
return EAS_SUCCESS;
}