diff options
| author | Harish Mahendrakar <harish.mahendrakar@ittiam.com> | 2018-10-24 17:42:25 -0700 |
|---|---|---|
| committer | Ray Essick <essick@google.com> | 2018-11-10 10:16:06 -0800 |
| commit | 442a01bf37d5bd97bb6d13b382f00265051abbe8 (patch) | |
| tree | a839dccfc2631afc8d3f6f309d304941383293a8 | |
| parent | 1863b7cc038918298728488d57667d97c5cd505d (diff) | |
| download | android_external_libavc-442a01bf37d5bd97bb6d13b382f00265051abbe8.tar.gz android_external_libavc-442a01bf37d5bd97bb6d13b382f00265051abbe8.tar.bz2 android_external_libavc-442a01bf37d5bd97bb6d13b382f00265051abbe8.zip | |
decoder: Signal IVD_RES_CHANGED error for change in crop params
IVD_RES_CHANGED was not signaled when crop parameters changed, i.e.
display dimensions changed without change in decode dimensions.
In such cases, if output buffer was allocated as per the current
dimension being decoded, without IVD_RES_CHANGED signalled, there can be
an OOB write if the new buffer is smaller than the frame being returned
as output
Bug: 118399205
Test: vendor
Change-Id: Ia750a99cda08a3254a6f8ea8b55d07e655b34d05
| -rw-r--r-- | decoder/ih264d_parse_headers.c | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/decoder/ih264d_parse_headers.c b/decoder/ih264d_parse_headers.c index b669331..ee38315 100644 --- a/decoder/ih264d_parse_headers.c +++ b/decoder/ih264d_parse_headers.c @@ -918,12 +918,25 @@ WORD32 ih264d_parse_sps(dec_struct_t *ps_dec, dec_bit_stream_t *ps_bitstrm) ps_dec->u1_res_changed = 1; return IVD_RES_CHANGED; } + + if((ps_dec->i4_header_decoded & 1) && (ps_dec->u2_disp_width != i4_cropped_wd)) + { + ps_dec->u1_res_changed = 1; + return IVD_RES_CHANGED; + } + if((ps_dec->i4_header_decoded & 1) && (ps_dec->u2_pic_ht != u2_pic_ht)) { ps_dec->u1_res_changed = 1; return IVD_RES_CHANGED; } + if((ps_dec->i4_header_decoded & 1) && (ps_dec->u2_disp_height != i4_cropped_ht)) + { + ps_dec->u1_res_changed = 1; + return IVD_RES_CHANGED; + } + /* Check for unsupported resolutions */ if((u2_pic_wd > H264_MAX_FRAME_WIDTH) || (u2_pic_ht > H264_MAX_FRAME_HEIGHT)) { |