summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBart De Schuymer <bdschuym@pandora.be>2011-06-23 18:42:28 +0000
committerBart De Schuymer <bdschuym@pandora.be>2011-06-23 18:42:28 +0000
commit40b1d5a9213ea95adad12517559c31ff1b6ec446 (patch)
tree76e35aee8a775f5d123e25eb39895d145854326d
parentfd54852e00243e6986a9d6224bb0ac746559e964 (diff)
downloadandroid_external_ebtables-40b1d5a9213ea95adad12517559c31ff1b6ec446.tar.gz
android_external_ebtables-40b1d5a9213ea95adad12517559c31ff1b6ec446.tar.bz2
android_external_ebtables-40b1d5a9213ea95adad12517559c31ff1b6ec446.zip
remove irrelevant negative value check for the result of strtoul, found by Coverity static analysis (thanks to Jiri Popelka)
-rw-r--r--userspace/ebtables2/extensions/ebt_nflog.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/userspace/ebtables2/extensions/ebt_nflog.c b/userspace/ebtables2/extensions/ebt_nflog.c
index 259bdb2..0cd10e0 100644
--- a/userspace/ebtables2/extensions/ebt_nflog.c
+++ b/userspace/ebtables2/extensions/ebt_nflog.c
@@ -80,8 +80,6 @@ static int nflog_parse(int c, char **argv, int argc,
i = strtoul(optarg, &end, 10);
if (*end != '\0')
ebt_print_error2("--nflog-group must be a number!");
- if (i < 0)
- ebt_print_error2("--nflog-group can not be negative");
info->group = i;
break;
@@ -92,8 +90,6 @@ static int nflog_parse(int c, char **argv, int argc,
i = strtoul(optarg, &end, 10);
if (*end != '\0')
ebt_print_error2("--nflog-range must be a number!");
- if (i < 0)
- ebt_print_error2("--nflog-range can not be negative");
info->len = i;
break;
@@ -104,9 +100,6 @@ static int nflog_parse(int c, char **argv, int argc,
i = strtoul(optarg, &end, 10);
if (*end != '\0')
ebt_print_error2("--nflog-threshold must be a number!");
- if (i < 0)
- ebt_print_error2
- ("--nflog-threshold can not be negative");
info->threshold = i;
break;
case NFLOG_NFLOG: