diff options
author | Jean-Michel Trivi <jmtrivi@google.com> | 2016-03-21 14:12:19 -0700 |
---|---|---|
committer | Feng Yu <feny@google.com> | 2016-04-20 16:20:38 -0700 |
commit | 914c69093c4e529c822f6b15942852ccbd2c51a8 (patch) | |
tree | 1890fa95db14a23bc83aea6eec77568e3f4ff661 | |
parent | a58176fe1b8ca24b148ffaf276ca0d6efc45c801 (diff) | |
download | android_external_aac-914c69093c4e529c822f6b15942852ccbd2c51a8.tar.gz android_external_aac-914c69093c4e529c822f6b15942852ccbd2c51a8.tar.bz2 android_external_aac-914c69093c4e529c822f6b15942852ccbd2c51a8.zip |
Fix stack corruption happening in aacDecoder_drcExtractAndMap()
In the aacDecoder_drcExtractAndMap() function, self->numThreads
can be used after having exceeded its intended max value,
MAX_DRC_THREADS, causing memory to be cleared after the
threadBs[MAX_DRC_THREADS] array.
The crash is prevented by never using self->numThreads with
a value equal to or greater than MAX_DRC_THREADS.
A proper fix will be required as there seems to be an issue as
to which entry in the threadBs array is meant to be initialized
and used.
Bug 26751339
Change-Id: Ibd76e3877e75f246f4b5bf0f1cfd0da0373106df
-rw-r--r-- | libAACdec/src/aacdec_drc.cpp | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/libAACdec/src/aacdec_drc.cpp b/libAACdec/src/aacdec_drc.cpp index 0c33a2b..9cfc5d5 100644 --- a/libAACdec/src/aacdec_drc.cpp +++ b/libAACdec/src/aacdec_drc.cpp @@ -2,7 +2,7 @@ /* ----------------------------------------------------------------------------------------------------------- Software License for The Fraunhofer FDK AAC Codec Library for Android -© Copyright 1995 - 2013 Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e.V. +© Copyright 1995 - 2013 Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e.V. All rights reserved. 1. INTRODUCTION @@ -705,6 +705,10 @@ static int aacDecoder_drcExtractAndMap ( } self->numPayloads = 0; + if (self->numThreads >= MAX_DRC_THREADS) { + self->numThreads = MAX_DRC_THREADS - 1; + } + if (self->dvbAncDataAvailable) { /* Append a DVB heavy compression payload thread if available. */ int bitsParsed; @@ -731,6 +735,10 @@ static int aacDecoder_drcExtractAndMap ( /* coupling channels not supported */ + if (self->numThreads >= MAX_DRC_THREADS) { + self->numThreads = MAX_DRC_THREADS - 1; + } + /* check for valid threads */ for (thread = 0; thread < self->numThreads; thread++) { CDrcPayload *pThreadBs = &threadBs[thread]; |