diff options
| author | Yu Ning <yu.ning@intel.com> | 2015-08-07 18:26:48 +0000 |
|---|---|---|
| committer | Android Git Automerger <android-git-automerger@android.com> | 2015-08-07 18:26:48 +0000 |
| commit | f378402be9f51ed17eacbbd65f786d304bcb8dda (patch) | |
| tree | e33cc2539d76db0a5359a4381132c48124db955d | |
| parent | 8e39c79622b79f4b5faf53123acefa5c5bda5eed (diff) | |
| parent | e40e60a6ad91ac2c42837d1a9cb84037cc2a6e5f (diff) | |
| download | android_device_generic_goldfish-f378402be9f51ed17eacbbd65f786d304bcb8dda.tar.gz android_device_generic_goldfish-f378402be9f51ed17eacbbd65f786d304bcb8dda.tar.bz2 android_device_generic_goldfish-f378402be9f51ed17eacbbd65f786d304bcb8dda.zip | |
am e40e60a6: DO NOT MERGE opengl: Fix QemuPipeStream::readFully reading beyond end of buffer
* commit 'e40e60a6ad91ac2c42837d1a9cb84037cc2a6e5f':
DO NOT MERGE opengl: Fix QemuPipeStream::readFully reading beyond end of buffer
| -rw-r--r-- | opengl/system/OpenglSystemCommon/QemuPipeStream.cpp | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/opengl/system/OpenglSystemCommon/QemuPipeStream.cpp b/opengl/system/OpenglSystemCommon/QemuPipeStream.cpp index 5798370..3a53161 100644 --- a/opengl/system/OpenglSystemCommon/QemuPipeStream.cpp +++ b/opengl/system/OpenglSystemCommon/QemuPipeStream.cpp @@ -122,12 +122,14 @@ const unsigned char *QemuPipeStream::readFully(void *buf, size_t len) //DBG(">> QemuPipeStream::readFully %d\n", len); if (!valid()) return NULL; if (!buf) { - if (len>0) ERR("QemuPipeStream::readFully failed, buf=NULL, len %d", len); + if (len > 0) { + ERR("QemuPipeStream::readFully failed, buf=NULL, len %zu", len); + } return NULL; // do not allow NULL buf in that implementation } size_t res = len; while (res > 0) { - ssize_t stat = ::read(m_sock, (char *)(buf) + len - res, len); + ssize_t stat = ::read(m_sock, (char *)(buf) + len - res, res); if (stat == 0) { // client shutdown; return NULL; @@ -135,8 +137,8 @@ const unsigned char *QemuPipeStream::readFully(void *buf, size_t len) if (errno == EINTR) { continue; } else { - ERR("QemuPipeStream::readFully failed (buf %p): %s\n", - buf, strerror(errno)); + ERR("QemuPipeStream::readFully failed (buf %p, len %zu" + ", res %zu): %s\n", buf, len, res, strerror(errno)); return NULL; } } else { |