diff options
author | Aart Bik <ajcbik@google.com> | 2016-04-21 15:51:41 -0700 |
---|---|---|
committer | Jessica Wagantall <jwagantall@cyngn.com> | 2016-07-08 13:31:40 -0700 |
commit | 2198d9b9c93d92523b08056726114650f3f8e545 (patch) | |
tree | af92ab9d48f2512c212069968c49cfc8af357373 | |
parent | 0f6f6f415ba263e29ba8ee1294444ae383492a40 (diff) | |
download | android_dalvik-stable/cm-12.1-YOG4P.tar.gz android_dalvik-stable/cm-12.1-YOG4P.tar.bz2 android_dalvik-stable/cm-12.1-YOG4P.zip |
Fix potential buffer overrun.stable/cm-12.1-YOG4P
BUG=27840771
CYNGNOS-3020
Change-Id: I240f188b2e8f4b45d90138cfb3b14869cf506452
(cherry picked from commit 38025bc7fa31b231ae7b1575e0faf62a7f0953cf)
-rw-r--r-- | libdex/OptInvocation.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/libdex/OptInvocation.cpp b/libdex/OptInvocation.cpp index 031ec9177..a9ea3a2d5 100644 --- a/libdex/OptInvocation.cpp +++ b/libdex/OptInvocation.cpp @@ -89,9 +89,9 @@ char* dexOptGenerateCacheFileName(const char* fileName, const char* subFileName) ALOGE("Can't get CWD while opening jar file"); return NULL; } - strncat(absoluteFile, "/", kBufLen); + strncat(absoluteFile, "/", kBufLen - strlen(absoluteFile)); } - strncat(absoluteFile, fileName, kBufLen); + strncat(absoluteFile, fileName, kBufLen - strlen(absoluteFile)); /* * Append the name of the Jar file entry, if any. This is not currently @@ -99,8 +99,8 @@ char* dexOptGenerateCacheFileName(const char* fileName, const char* subFileName) * in a Jar. */ if (subFileName != NULL) { - strncat(absoluteFile, "/", kBufLen); - strncat(absoluteFile, subFileName, kBufLen); + strncat(absoluteFile, "/", kBufLen - strlen(absoluteFile)); + strncat(absoluteFile, subFileName, kBufLen - strlen(absoluteFile)); } /* Turn the path into a flat filename by replacing @@ -138,7 +138,7 @@ char* dexOptGenerateCacheFileName(const char* fileName, const char* subFileName) /* Tack on the file name for the actual cache file path. */ - strncat(nameBuf, absoluteFile, kBufLen); + strncat(nameBuf, absoluteFile, kBufLen - strlen(nameBuf)); ALOGV("Cache file for '%s' '%s' is '%s'", fileName, subFileName, nameBuf); return strdup(nameBuf); |